Make ImplicitVolume updateable #228
Open
+92
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ... so `density_blob_scale` can be annealed over time - zero123 changes that might improve quality, and - ... anneal the density_blob_scale, which might help in later phases experiment: test110_zero123_500steps_lots_of_changes
bennyguo
requested changes
Jul 12, 2023
| from threestudio.utils.ops import get_activation | ||
| from threestudio.utils.typing import * | ||
|
|
||
|
|
||
| @threestudio.register("implicit-volume") | ||
| class ImplicitVolume(BaseImplicitGeometry): | ||
| class ImplicitVolume(BaseImplicitGeometry, Updateable): |
There was a problem hiding this comment.
This is not needed as BaseImplicitGeometry (inherit from BaseModule) is already Updateable.
voletiv
reviewed
Jul 12, 2023
| @@ -25,12 +25,12 @@ data: # threestudio/data/image.py -> SingleImageDataModuleConfig | |||
| eval_batch_size: 1 | |||
| elevation_range: [-10, 80] | |||
| azimuth_range: [-180, 180] | |||
| camera_distance_range: [3.8, 3.8] | |||
| camera_distance_range: [3.8, 3.85] | |||
There was a problem hiding this comment.
Do we want these changes to be permanent? Since it's 500 iters, it will be slower than the current config. Instead, maybe add another yaml file with these changes called configs/experimental/zero123_updated.yaml?
There was a problem hiding this comment.
I believe the extra steps and the hyperparam changes are worth it in terms of higher quality... @voletiv do you mind testing it out with a few of your images?
There was a problem hiding this comment.
Actually... hold on, I want to run a few more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
density_blob_scalecan be annealed over time